Remove diff feature #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milhouse's diffs are currently unused in Lighthouse, because we've opted to use
xdelta3instead. The diffs fromxdelta3over a binaryBeaconStateare around 12x smaller, and take a similar amount of time to compute (source). Using the same diff algorithm for the historic states and hot states also provides a nice simplification.By removing the diff feature from Milhouse, we make reviews & refactors easier. In particular, I would still like to pursue the "large nodes" optimisation, which cut across all parts of the codebase.
In future we could revive the diff feature by reverting this PR.