Slow peer scoring #556
Merged
Slow peer scoring #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Mar 7, 2024
| @@ -739,6 +750,14 @@ where | |||
| ) | |||
| .is_err() | |||
| { | |||
| self.failed_messages.entry(*peer_id).or_default().priority += 1; | |||
There was a problem hiding this comment.
if a peer is in the mesh, and the policy is to drop messages, they will see an incomplete message stream which seems to me like it could lead to an inconsistent view of the universe - ie in a burst of messages, they'll get some, but not others.
For non-mesh-peers, this would be plugged with IHAVE, but not for mesh peers.. thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a way to integrate slow peers into the 1.1 scoring message and also adds a message to inform the application if a peer is dropping messages.