-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement EIP-7495: StableContainer #15
base: main
Are you sure you want to change the base?
Conversation
Just pushed a smol commit (5c10761) to fix the duplicate dependency issues. The problem was the non- Long-term I don't think this will be needed, as there'll be proper releases to depend on. Although I do wonder if there's a circular dependency now?
and our release strategy previously was:
whereas now it might have to be:
|
f858e7e
to
b614143
Compare
@@ -224,11 +502,11 @@ fn tree_hash_derive_enum_transparent( | |||
#( | |||
assert_eq!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion seems to prevent you from using superstruct with a transparent (or transparent_stable) tree_hash
marker where one variant is a normal container and the other is a profile. This seems like a useful thing to do. Is there a way around this?
EIP: https://eips.ethereum.org/EIPS/eip-7495
Related PR: sigp/ethereum_ssz#16