Implement TreeHash for Option
#8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, there is no standardized way of implementing Optional values in SSZ.
This will change with
The Vergeas the current spec uses optional values. The exact specification has not been agreed upon however the current Kaustinen testnet is usingUnion[None, T].Another method which could be considered is: https://eips.ethereum.org/EIPS/eip-6475
This PR implements
TreeHashforOption<T>using theUnion[None, T]method.There is no expectation of this PR in its current state being merged, although it is here as a reference as this feature will be necessary at some point in the future.