-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create helper for fulcio config yaml #803
Create helper for fulcio config yaml #803
Conversation
b1918f5
to
fc26fd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, what was the error you were getting with the previous code?
I've got this one:
|
Signed-off-by: Javan lacerda <[email protected]>
fc26fd7
to
a092a06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm, this was tested locally with json and yaml configs and was working?
I tested for the default value, that is json. I'm doing a double check here. |
Signed-off-by: Javan lacerda <[email protected]>
It is 100% tested now, working properly for json and yaml |
Description of the change
I noticed that this condition was not working properly when I was bumping the fulcio version in scaffold.
Then I managed to move the logic of create the config with yaml format into the helper and setting the indent correctly.
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yaml
according to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.