feat: add webhook timeout values #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: falcorocks <[email protected]>
falcorocks
force-pushed
the
feat-timeout-values
branch
from
07c910c to
e3ef902
Compare
hectorj2f
reviewed
Jan 20, 2025
hectorj2f
reviewed
Jan 20, 2025
Signed-off-by: falcorocks <[email protected]>
falcorocks
force-pushed
the
feat-timeout-values
branch
from
e2d6a8c to
b4d18f4
Compare
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
TomWKraken
reviewed
Jan 21, 2025
| "default": "sha256:f291fce5b9c1a69ba54990eda7e0fe4114043b1afefb0f4ee3e6f84ec9ef1605", | ||
| "description": "crane digest ghcr.io/sigstore/policy-controller/policy-controller:v0.8.2", | ||
| "default": "sha256:f3b57d4c906fcbd7229c3069c055ce2b2862e01106c2b85df1322f1e3a232829", | ||
| "description": "crane digest ghcr.io/sigstore/policy-controller/policy-controller:v0.11.0", |
There was a problem hiding this comment.
Suggested change
| "description": "crane digest ghcr.io/sigstore/policy-controller/policy-controller:v0.11.0", | |
| "description": "crane digest ghcr.io/sigstore/policy-controller/policy-controller:v0.12.0", |
There was a problem hiding this comment.
falcorocks
commented
Jan 21, 2025
Signed-off-by: falcorocks <[email protected]>
hectorj2f
approved these changes
Jan 21, 2025
|
thank you @hectorj2f @bobcallaway ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds optional timeout values. The chart creates 4 webhook configuration objects (2
ValidatingWebhookConfigurationand 2MutatingWebhookConfiguration. These are all created with the defaulttimeoutSeconds(docs) set to 10s. In some cases this is excessive (Kuberentes docs recommend this value to be as short as possible). In other cases user experience the need for longer timeouts, up to 20 seconds. This PR allows users to specify a specific timeout for each of the 4 configurations.Existing or Associated Issue(s)
see for instance https://sigstore.slack.com/archives/C03096V09F1/p1737372057769759
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.