Switch to avast/retry-go for HTTP retry
#2350
Open
+100
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
commented
Jan 29, 2025
Comment on lines
+135
to
+138
| retry.Delay(rt.options.RetryWaitMin), | ||
| retry.MaxDelay(rt.options.RetryWaitMax), |
There was a problem hiding this comment.
This may behave different now. Worth double checking if that's intentional.
saschagrunert
force-pushed
the
retry-go
branch
from
b29bc95 to
a782ddc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
===========================================
- Coverage 66.46% 49.87% -16.60%
===========================================
Files 92 192 +100
Lines 9258 24774 +15516
===========================================
+ Hits 6153 12355 +6202
- Misses 2359 11316 +8957
- Partials 746 1103 +357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saschagrunert
force-pushed
the
retry-go
branch
5 times, most recently
from
2f03510 to
9ae3e8f
Compare
The hashicorp dependencies are MPL licensed and therefore not allowed in the CNCF. This means we now use the `avast/retry-go` implementation to achieve the same goal. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
retry-go
branch
from
9ae3e8f to
003ab22
Compare
|
Green CI :) |
cpanato
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The hashicorp dependencies are MPL licensed and therefore not allowed in the CNCF. This means we now use the
avast/retry-goimplementation to achieve the same goal.Release Note
Use
github.com/avast/retry-goinstead ofgithub.com/hashicorp/go-retryablehttpfor HTTP request retry.Documentation
None
Fixes #2342