Add CertificateAuthority #1200
Merged
Add CertificateAuthority #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis <[email protected]>
Signed-off-by: Alexis <[email protected]>
Signed-off-by: Alexis <[email protected]>
woodruffw
reviewed
Oct 31, 2024
woodruffw
reviewed
Oct 31, 2024
woodruffw
reviewed
Oct 31, 2024
woodruffw
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Thanks @DarkaMaul! This is a good start, but I think it can be simplified quite a bit -- we don't need to be so stringent about classifying the different members of the CertificateAuthority message, since they all end up in a trust "pool" anyways for chain building purposes 🙂
woodruffw
added
component:verification
I've updated the code to remove the distinction between all the different certificates 👍 |
DarkaMaul
force-pushed
the
dm/verify-timestamp
branch
from
6cad8bb to
eac665f
Compare
Signed-off-by: Alexis <[email protected]>
DarkaMaul
force-pushed
the
dm/verify-timestamp
branch
from
eac665f to
4add4cd
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up on #1182, this PR adds a
CertificateAuthorityclass to the trust and uses it to retrieve both Fulcio certificates and Timestamping Authorities.