Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: windows: Update Qt #497

Closed
wants to merge 2 commits into from
Closed

CI: windows: Update Qt #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b2d47d
CI: windows: Update Qt
syyyr Oct 8, 2024
30d9f09
windows: Don't add unicode
syyyr Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
uses: ./.github/actions/build-and-test

windows:
name: Qt 6.5.3 / Windows
name: Qt 6.7.2 / Windows
runs-on: windows-2022
steps:
- uses: actions/checkout@v4
Expand All @@ -87,7 +87,7 @@ jobs:
- name: Setup CMake
uses: ./.github/actions/cmake
with:
qt_version: 6.5.3
qt_version: 6.7.2
qt_arch: win64_mingw
use_qt6: ON
modules: qtserialport qtwebsockets
Expand Down
4 changes: 0 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,6 @@ if(LIBSHV_WITH_COREQT)

function(qt_add_library target)
add_library(${target} ${ARGN})
if(WIN32)
target_compile_definitions(${target} PRIVATE UNICODE)
target_compile_definitions(${target} PRIVATE _UNICODE)
endif()
endfunction()

function(qt_add_executable)
Expand Down
Loading