enable save result to file #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syyyr
requested changes
Jan 19, 2024
MartinKT
force-pushed
the
save-result-to-file
branch
from
0b40e4f to
03c194d
Compare
syyyr
approved these changes
Jan 19, 2024
|
Díky za opravy |
|
Ty faily na clazy clang-tidy ignorujte teď, je to bug |
fvacek
reviewed
Jan 21, 2024
shvspy/src/mainwindow.cpp
Outdated
| @@ -420,8 +420,14 @@ void MainWindow::displayValue(const shv::chainpack::RpcValue &rv) | |||
| view->setAttribute(Qt::WA_DeleteOnClose); | |||
| view->setWindowIconText(tr("Result")); | |||
| view->setReadOnly(true); | |||
| std::pair<const char *, size_t> data = rv.asData(); | |||
| view->setText(QString::fromUtf8(std::get<0>(data), std::get<1>(data))); | |||
| auto rv_data = rv.asData(); | |||
There was a problem hiding this comment.
auto [blob, size] = rv.asData();
auto data = QByteArray::fromRawData(blob, size);is more readable
There was a problem hiding this comment.
Opraveno, super tip.
MartinKT
force-pushed
the
save-result-to-file
branch
from
03c194d to
3994b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.