Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get credentials from user's terraform config directory #76

Merged
merged 8 commits into from
Sep 19, 2024
Merged

get credentials from user's terraform config directory #76

merged 8 commits into from
Sep 19, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Sep 16, 2024 •
edited
Loading

ITSE-1492 tfc-ops: use API token in dotfiles

Resolves #54

@briskt briskt requested review from a team, jason-jackson and hobbitronics and removed request for a team September 16, 2024 10:11
forevermatt
forevermatt approved these changes Sep 18, 2024
View reviewed changes
Copy link

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what looks like one typo, but otherwise (to my untrained eye for Go) it all looks fine.

cmd/root.go Outdated Show resolved Hide resolved
jason-jackson
jason-jackson approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments (also echoing Matts spelling comment too)

.github/workflows/release.yml Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt merged commit 1c80ff8 into release/v4.0.0 Sep 19, 2024
3 checks passed
@briskt briskt deleted the feature/terraform-creds branch September 19, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@forevermatt forevermatt forevermatt approved these changes

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics was automatically assigned from silinternational/go-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @forevermatt @jason-jackson