Feature: Reference Parsing #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedcolbert
changed the title
jakedcolbert
force-pushed
the
feature/footnote-ref/388
branch
5 times, most recently
from
9c73ac4
to
b06f276
Compare
|
Ready for review @chrisvire |
jakedcolbert
changed the title
|
@jakedcolbert I am going through PRs and noticed this one. Do you believe this is ready? |
|
@chrisvire Yes, it meets the requirements of #388. It does not handle verse list separators or books with single chapter formats like 'Jude 6' |
added 5 commits
November 6, 2023 11:00
* Develop utilities for parsing in text references and generating respective HTML content. * Develop tests to evaluate effectiveneess of developed functions * Develop footnote content display component with stack functionality.
jakedcolbert
force-pushed
the
feature/footnote-ref/388
branch
from
96c7660
to
3aa4405
Compare
|
@jakedcolbert I am confused on what I should be looking for? Is there specific Langauage/Book/Chapter/Verse where I can see this in action? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #388
respective HTML content.