Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run App Builders during Test Workflow #734

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Conversation

chrisvire
Copy link
Member

@chrisvire chrisvire commented Nov 26, 2024

Separate the testing from the Lint workflow. Run App Builders from the latest release against projects instead of depending on example_data folder, which is stale.

Include test projects in test_data/projects for SAB and DAB.

Add npm run extract:example <project_name> to use test projects for development.

@chrisvire chrisvire force-pushed the feature/action-appbuilder branch 13 times, most recently from 9bffd5f to bc994a7 Compare November 27, 2024 00:00
@chrisvire
Copy link
Member Author

@davidmoore1 I would like to review this with you. Should we get rid of the example_data? Or how do we keep it up to date? The best would be to have a script in package.json to generate data from the /test_data/projects, but it would have to be cross-platform...

Copy link
Contributor

@davidmoore1 davidmoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we said during the meeting, it would be good to be able to come up with a replacement for the build examples that builds the checked in projects. But that can be done as a separate PR.

@chrisvire chrisvire changed the title Run App Builders during lint process Run App Builders during Test Workflow Nov 27, 2024
@chrisvire chrisvire self-assigned this Nov 27, 2024
@chrisvire chrisvire linked an issue Nov 27, 2024 that may be closed by this pull request
@chrisvire
Copy link
Member Author

But that can be done as a separate PR.

This was too much fun to wait for another PR. Thanks you ChatGPT:
https://chatgpt.com/share/6747aa90-542c-8006-8d69-985b3a1768fb

@chrisvire chrisvire merged commit cfbd825 into main Nov 27, 2024
2 checks passed
@chrisvire chrisvire deleted the feature/action-appbuilder branch November 27, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AppBuilder in Lint
2 participants