-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run App Builders during Test Workflow #734
Conversation
9bffd5f
to
bc994a7
Compare
@davidmoore1 I would like to review this with you. Should we get rid of the example_data? Or how do we keep it up to date? The best would be to have a script in package.json to generate data from the /test_data/projects, but it would have to be cross-platform... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we said during the meeting, it would be good to be able to come up with a replacement for the build examples that builds the checked in projects. But that can be done as a separate PR.
* Remove the example_data folder * Run `npm run extract:example <project_name>` to generate data to the /data folder from an example. * This uses SAB or DAB installed at the default location.
8210381
to
9eba7d5
Compare
This was too much fun to wait for another PR. Thanks you ChatGPT: |
Separate the testing from the Lint workflow. Run App Builders from the latest release against projects instead of depending on
example_data
folder, which is stale.Include test projects in
test_data/projects
for SAB and DAB.Add
npm run extract:example <project_name>
to use test projects for development.