Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding hg.exe location with env vars #353

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Oct 29, 2024

Fix #352.

Three env vars are defined, one that sets the path to the Mercurial executable directly (overriding both folder and exe name), one that just overrides the folder and lets Chorus pick the exe name, and one that just overrides the exe name and lets Chorus pick the folder.


This change is Reviewable

Three env vars are defined, one that sets the path to the Mercurial
executable directly (overriding both folder and exe name), one that
just overrides the folder and lets Chorus pick the exe name, and one
that just overrides the exe name and lets Chorus pick the folder.
@rmunn rmunn self-assigned this Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

Test Results

       4 files  ±0     412 suites  ±0   2h 45m 56s ⏱️ +10s
   883 tests ±0     860 ✔️ ±0    23 💤 ±0  0 ±0 
4 040 runs  ±0  3 906 ✔️ ±0  134 💤 ±0  0 ±0 

Results for commit 179726a. ± Comparison against base commit a6a7041.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I would make one change so that if the CHORUS_PATH_TO_HG_EXECUTABLE variable is an empty string it won't do anything

src/LibChorus/MercurialLocation.cs Outdated Show resolved Hide resolved
@rmunn rmunn requested a review from hahn-kev November 5, 2024 08:37
@rmunn rmunn enabled auto-merge (squash) November 7, 2024 06:00
@rmunn rmunn merged commit 15f8823 into master Nov 7, 2024
4 checks passed
@rmunn rmunn deleted the feat/get-hg-location-from-env-vars branch November 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding path to Mercurial via environment variable
2 participants