Skip to content

Validate MiniLcm types #611

Validate MiniLcm types

Validate MiniLcm types #611

Triggered via pull request January 9, 2025 15:54
Status Failure
Total duration 9m 18s
Artifacts

fw-lite.yaml

on: pull_request
Build FW Lite and run tests
9m 3s
Build FW Lite and run tests
Publish FW Lite app for Mac
0s
Publish FW Lite app for Mac
Publish FW Lite app for Linux
0s
Publish FW Lite app for Linux
Publish FW Lite app for Android
0s
Publish FW Lite app for Android
Publish FW Lite app for Windows
0s
Publish FW Lite app for Windows
Create Release
0s
Create Release
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 10 warnings
Build FW Lite and run tests: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L144
'MiniLcmValidators' does not contain a definition for 'ValidateAndThrowAsync' and the best extension method overload 'DefaultValidatorExtensions.ValidateAndThrowAsync<SemanticDomain>(IValidator<SemanticDomain>, SemanticDomain, CancellationToken)' requires a receiver of type 'FluentValidation.IValidator<MiniLcm.Models.SemanticDomain>'
Build FW Lite and run tests: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L160
'MiniLcmValidators' does not contain a definition for 'ValidateAndThrowAsync' and the best extension method overload 'DefaultValidatorExtensions.ValidateAndThrowAsync<SemanticDomain>(IValidator<SemanticDomain>, SemanticDomain, CancellationToken)' requires a receiver of type 'FluentValidation.IValidator<MiniLcm.Models.SemanticDomain>'
Build FW Lite and run tests
Process completed with exit code 1.
Build FW Lite and run tests: backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L209
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build FW Lite and run tests: backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
Build FW Lite and run tests: backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
Build FW Lite and run tests: backend/FwLite/LcmCrdt/CrdtProjectsService.cs#L25
The default value specified for parameter 'saveChangesOnDispose' will have no effect because it applies to a member that is used in contexts that do not allow optional arguments
Build FW Lite and run tests: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
Build FW Lite and run tests: backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build FW Lite and run tests: backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build FW Lite and run tests: backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
Build FW Lite and run tests: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L390
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build FW Lite and run tests: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'