Address various review comments

sillsdev · Jan 8, 2025 · 295c23e · 295c23e
1 parent dd15ca8
commit 295c23e
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 13 deletions.
diff --git a/backend/FwLite/LcmCrdt.Tests/Changes/JsonPatchChangeTests.cs b/backend/FwLite/LcmCrdt.Tests/Changes/JsonPatchChangeTests.cs
@@ -37,14 +37,4 @@ public void NewChangeIPatchDoc_ThrowsForRemoveAtIndex()
         var act = () => new JsonPatchChange<Entry>(Guid.NewGuid(), patch);
         act.Should().Throw<NotSupportedException>();
     }
-
-    // TODO: Doesn't work now that Sense.PartOfSpeech is an object. Rewrite or toss?
-    // [Fact]
-    // public void NewPatchDoc_ThrowsForIndexBasedPath()
-    // {
-    //     var patch = new JsonPatchDocument<Entry>();
-    //     patch.Replace(entry => entry.Senses[0].PartOfSpeech, "noun");
-    //     var act = () => new JsonPatchChange<Entry>(Guid.NewGuid(), patch);
-    //     act.Should().Throw<NotSupportedException>();
-    // }
 }
diff --git a/backend/FwLite/LcmCrdt/Changes/SetPartOfSpeechChange.cs b/backend/FwLite/LcmCrdt/Changes/SetPartOfSpeechChange.cs
@@ -12,7 +12,6 @@ public override async ValueTask ApplyChange(Sense entity, ChangeContext context)
         if (PartOfSpeechId is null)
         {
             entity.PartOfSpeechId = null;
-            entity.PartOfSpeech = null;
             return;
         }
 

diff --git a/backend/FwLite/MiniLcm/SyncHelpers/SenseSync.cs b/backend/FwLite/MiniLcm/SyncHelpers/SenseSync.cs
@@ -35,7 +35,6 @@ public static async Task<int> Sync(Guid entryId,
 
         if (beforeSense.PartOfSpeechId != afterSense.PartOfSpeechId)
         {
-            patchDocument.Replace(sense => sense.PartOfSpeech, afterSense.PartOfSpeech);
             patchDocument.Replace(sense => sense.PartOfSpeechId, afterSense.PartOfSpeechId);
         }
 

diff --git a/backend/LfClassicData/LfClassicMiniLcmApi.cs b/backend/LfClassicData/LfClassicMiniLcmApi.cs
@@ -173,7 +173,7 @@ private async IAsyncEnumerable<Entry> Query(QueryOptions? options = null, string
 
         await foreach (var entry in Entries.Aggregate(pipeline).ToAsyncEnumerable())
         {
-            yield return await ToEntry(entry); // TODO: Is there a way to turn this into a .Select()? Because "yield return await" looks a little unwieldy
+            yield return await ToEntry(entry);
         }
     }
-Original file line number
+Diff line change
@@ Expand Up @@
             if (PartOfSpeechId is null)
             {
                 entity.PartOfSpeechId = null;
-                entity.PartOfSpeech = null;
                 return;
             }
@@ Expand Down @@