Address review comments

sillsdev · Nov 13, 2024 · 4139190 · 4139190
1 parent 2fa7bbb
commit 4139190
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/frontend/src/lib/components/IconButton.svelte b/frontend/src/lib/components/IconButton.svelte
@@ -13,7 +13,6 @@
   let loadingSize = size === 'btn-sm' ? 'loading-xs' as const : undefined;
   export let outline = variant !== 'btn-ghost';
   export let fake = false; // for display purposes only
-  export let title: string | undefined = undefined;
 
   const xlIcons: IconString[] = ['i-mdi-refresh'];
   $: textSize = xlIcons.includes(icon) ? 'text-xl' : 'text-lg';
@@ -22,7 +21,6 @@
 <!-- type="button" ensures the button doen't act as a submit button when in a form -->
 <button type="button" on:click
   disabled={disabled && !loading}
-  {title}
   class:pointer-events-none={fake || loading}
   class="btn btn-square {variant ?? ''} {size ?? ''} {$$restProps.class ?? ''}"
   class:btn-outline={outline}

diff --git a/frontend/src/lib/components/Users/UserModal.svelte b/frontend/src/lib/components/Users/UserModal.svelte
@@ -35,7 +35,6 @@
 
   const { notifySuccess } = useNotifications();
 
-  // eslint-disable-next-line func-style
   async function sendVerificationEmail(user: User): Promise<void> {
     await _sendNewVerificationEmailByAdmin(user.id as UUID);
     notifySuccess($t('admin_dashboard.notifications.verification_email_sent', { email: user.email ?? '' }));
@@ -64,12 +63,13 @@
                 <span class="i-mdi-help-circle-outline" />
               </span>
               <AdminContent>
-                <IconButton
-                  size="btn-sm"
-                  icon="i-mdi-email"
-                  title={$t('admin_dashboard.resend_verification_email')}
-                  on:click={() => sendVerificationEmail(user)}
-                />
+                <div class="tooltip" data-tip={$t('admin_dashboard.resend_verification_email')}>
+                  <IconButton
+                    size="btn-sm"
+                    icon="i-mdi-email"
+                    on:click={() => sendVerificationEmail(user)}
+                  />
+                </div>
               </AdminContent>
             {/if}
           {:else}