Skip to content

Commit

Permalink
Chore/improve e2e tests in gha (#1270)
Browse files Browse the repository at this point in the history
* Trigger Develop API CI/CD on frontend changes

* Skip back button test in Firefox

* Make playwright task more accessible.
  • Loading branch information
myieye authored Nov 26, 2024
1 parent a525563 commit a598cae
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/develop-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
paths:
- 'backend/**'
- '!backend/FwLite/**'
- 'frontend/**'
- '.github/workflows/lexbox-api.yaml'
- '.github/workflows/deploy.yaml'
- 'deployment/lexbox-deployment.yaml'
Expand All @@ -14,6 +15,7 @@ on:
paths:
- 'backend/**'
- '!backend/FwLite/**'
- 'frontend/**'
- '.github/workflows/lexbox-api.yaml'
- '.github/workflows/deploy.yaml'
- 'deployment/lexbox-deployment.yaml'
Expand Down
3 changes: 2 additions & 1 deletion frontend/Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ tasks:
- corepack enable || true
- pnpm install
playwright-tests:
cmd: pnpm test
aliases: [ pt ]
cmd: pnpm run test {{.CLI_ARGS}}

playwright-generate-tests:
cmds:
Expand Down
3 changes: 2 additions & 1 deletion frontend/tests/logout.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import {AdminDashboardPage} from './pages/adminDashboardPage';
import {loginAs} from './utils/authHelpers';
import {test} from './fixtures';

test('Back button after logout redirects back to login page', async ({page}) => {
test('Back button after logout redirects back to login page', async ({page, browserName}) => {
test.skip(browserName === 'firefox', 'Support for Clear-Site-Data: "cache" was removed and is WIP (https://bugzilla.mozilla.org/show_bug.cgi?id=1838506)');
await loginAs(page.request, 'admin');
const adminPage = await new AdminDashboardPage(page).goto();
const drawer = await adminPage.openDrawer();
Expand Down

0 comments on commit a598cae

Please sign in to comment.