add a default value for GetLatestRelease cancellation token

sillsdev · Dec 9, 2024 · da8ba2c · da8ba2c
1 parent 05fbec0
commit da8ba2c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/backend/LexBoxApi/Controllers/FwLiteReleaseController.cs b/backend/LexBoxApi/Controllers/FwLiteReleaseController.cs
@@ -22,7 +22,7 @@ public class FwLiteReleaseController(FwLiteReleaseService releaseService) : Cont
     public async Task<ActionResult> DownloadLatest()
     {
         using var activity = LexBoxActivitySource.Get().StartActivity();
-        var latestRelease = await releaseService.GetLatestRelease(default);
+        var latestRelease = await releaseService.GetLatestRelease();
         if (latestRelease is null)
         {
             activity?.SetStatus(ActivityStatusCode.Error, "Latest release not found");
@@ -41,7 +41,7 @@ public async ValueTask<ActionResult<FwLiteRelease>> LatestRelease(string? appVer
     {
         using var activity = LexBoxActivitySource.Get().StartActivity();
         activity?.AddTag(FwLiteReleaseService.FwLiteClientVersionTag, appVersion ?? "unknown");
-        var latestRelease = await releaseService.GetLatestRelease(default);
+        var latestRelease = await releaseService.GetLatestRelease();
         activity?.AddTag(FwLiteReleaseService.FwLiteReleaseVersionTag, latestRelease?.Version);
         if (latestRelease is null) return NotFound();
         return latestRelease;

diff --git a/backend/LexBoxApi/Services/FwLiteReleases/FwLiteReleaseService.cs b/backend/LexBoxApi/Services/FwLiteReleases/FwLiteReleaseService.cs
@@ -12,7 +12,7 @@ public class FwLiteReleaseService(IHttpClientFactory factory, HybridCache cache)
     public const string FwLiteClientVersionTag = "app.fw-lite.client.version";
     public const string FwLiteReleaseVersionTag = "app.fw-lite.release.version";
 
-    public async ValueTask<FwLiteRelease?> GetLatestRelease(CancellationToken token)
+    public async ValueTask<FwLiteRelease?> GetLatestRelease(CancellationToken token = default)
     {
         return await cache.GetOrCreateAsync(GithubLatestRelease,
             FetchLatestReleaseFromGithub,
@@ -22,7 +22,7 @@ public class FwLiteReleaseService(IHttpClientFactory factory, HybridCache cache)
 
     public async ValueTask<ShouldUpdateResponse> ShouldUpdate(string appVersion)
     {
-        var latestRelease = await GetLatestRelease(default);
+        var latestRelease = await GetLatestRelease();
         if (latestRelease is null) return new ShouldUpdateResponse(null);
 
         var shouldUpdateToRelease = ShouldUpdateToRelease(appVersion, latestRelease.Version);