Skip to content

Commit

Permalink
Fix test failures around semantic domain IDs
Browse files Browse the repository at this point in the history
Now, instead of semantic domains always being considered predefined when
they come from fwdata, we can now look up their GUIDs in the canonical
list and set Predefined correctly. This also makes two failing tests pass.
  • Loading branch information
rmunn committed Jan 7, 2025
1 parent 1cedbec commit e5b02b7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ internal SemanticDomain FromLcmSemanticDomain(ICmSemanticDomain semanticDomain)
Id = semanticDomain.Guid,
Name = FromLcmMultiString(semanticDomain.Name),
Code = semanticDomain.Abbreviation.UiString ?? "",
Predefined = true, // TODO: Look up in a GUID list of predefined data
Predefined = CanonicalGuidsSemanticDomain.CanonicalSemDomGuids.Contains(semanticDomain.Guid),
};
}

Expand Down

0 comments on commit e5b02b7

Please sign in to comment.