Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW Lite push entry changes to frontend #1029

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Aug 21, 2024

this covers a couple things

  • lexbox has a signalR hub which pushes sync notifications to clients
  • fw lite listens to lexbox project change notifications, and triggers a sync for that project
  • after a crdt sync, the updated entries are pushed to the frontend

todo

  • improve responsiveness. Right now it takes a few seconds for clients to receive changes, that's when running locally, it will get worse over the internet.

Copy link

github-actions bot commented Aug 21, 2024

UI unit Tests

12 tests   12 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 4e2686c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 21, 2024

C# Unit Tests

66 tests   66 ✅  6s ⏱️
11 suites   0 💤
 1 files     0 ❌

Results for commit 4e2686c.

♻️ This comment has been updated with latest results.

@hahn-kev hahn-kev marked this pull request as ready for review August 27, 2024 08:08
@hahn-kev hahn-kev requested a review from rmunn August 27, 2024 08:08
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Again, lots of compiler warnings made this look larger than it actually was, so I opened #1042 to track getting rid of the ones that are truly safe to ignore. But this PR looks good.

@hahn-kev hahn-kev merged commit 99ff808 into develop Aug 29, 2024
19 checks passed
@hahn-kev hahn-kev deleted the chore/push-entry-changes-to-frontend branch August 29, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants