-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FW Lite push entry changes to frontend #1029
Conversation
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit 4e2686c. ♻️ This comment has been updated with latest results. |
C# Unit Tests66 tests 66 ✅ 6s ⏱️ Results for commit 4e2686c. ♻️ This comment has been updated with latest results. |
…otifications can be filtered by client id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Again, lots of compiler warnings made this look larger than it actually was, so I opened #1042 to track getting rid of the ones that are truly safe to ignore. But this PR looks good.
this covers a couple things
todo