-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove circular module dependency #1060
Remove circular module dependency #1060
Conversation
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit f002ab6. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix. My personal opinion is that the comment should go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not intend my last review to be a change request....even though it sort of is 😉
@myieye - Sure. Now that we're all aware of the issue, the comment has (mostly) served its purpose. Go ahead and re-review when you get into the office. |
Approved by Kevin, no need to wait for Tim
Fix #814.
The build warnings ultimately came from the fact that
$lib/forms/superforms.ts
imports a single function from.
(which in context is$lib/forms/index.ts
), while at the same time$lib/forms/index.ts
is importing and re-exporting everything, including thelexSuperForm
function that's used all over our Svelte components.There were three possible solutions:
manualChunks
option, requiring us to make decisions about what goes in every chunk. Not worth the cost and effort at this point.lexSuperForm
to import it from$lib/forms/superforms
instead of from$lib/forms
. This would have touched about a dozen files.$lib/forms/superforms.ts
to import from./utils
instead of from.
, thereby eliminating the circular import situation. This touches only a single line in a single file, but it eliminates the issue.Obviously, I went with option 3.