Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pnpm catalog feature for shared dependencies #1072

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Sep 25, 2024

I took the opportunity to peruse pnpm's changelog and found this handy new feature to prevent modules in a monorepo from using different versions of dependencies. For lots of dependencies it doesn't matter that much, but for some it does (e.g. vite and svelte) and consistency is nice.

In an intro video it was suggested to put everything in a catalog by default. But, the current caveat of catalogs is that they're not currently supported by pnpm update. Personally, I think we can live with that for the time being.

pnpm outdated works, which is something.

Copy link

github-actions bot commented Sep 25, 2024

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 8f4da2c. ± Comparison against base commit 23ab4d5.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the catalog is cool nice work.

frontend/Dockerfile Outdated Show resolved Hide resolved
@myieye myieye marked this pull request as ready for review September 26, 2024 14:34
@myieye myieye requested a review from hahn-kev September 26, 2024 14:34
@myieye myieye marked this pull request as draft September 26, 2024 14:45
@myieye myieye marked this pull request as ready for review September 27, 2024 11:51
@myieye myieye merged commit e799878 into develop Oct 4, 2024
12 checks passed
@myieye myieye deleted the feat/pnpm-catalog branch October 4, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants