Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer e2e tests #1120

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Viewer e2e tests #1120

merged 3 commits into from
Oct 16, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Oct 11, 2024 •
edited
Loading

Resolves #1118

Waiting for #1115

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 2201f50. ± Comparison against base commit 37a6fdf.

♻️ This comment has been updated with latest results.

hahn-kev
hahn-kev reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, though it fails for me, it looks like the order isn't correct

@hahn-kev hahn-kev linked an issue Oct 15, 2024 that may be closed by this pull request
E2E tests for viewer #1118
Closed
@myieye
Copy link
Contributor Author

myieye commented Oct 15, 2024

@hahn-kev Oh, sorry, this probably should have been a draft PR, because it depends on #1115

@myieye myieye marked this pull request as draft October 15, 2024 09:27
@myieye myieye marked this pull request as ready for review October 16, 2024 15:42
@myieye myieye merged commit 78d5e38 into develop Oct 16, 2024
14 checks passed
@myieye myieye deleted the viewer-basic-e2e-test branch October 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahn-kev hahn-kev hahn-kev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E tests for viewer
2 participants
@myieye @hahn-kev