Make reusable minilcm tests out of FW data tests #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation, update tests to reflect that
… text and will lookup the part of speech
rmunn
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Having tests in the *TestBase classes threw me at first, until I realized that it was a way of making the same tests run in several different environments. I wonder if there's a different way of achieving this without putting code into the abstract base class. But I don't want to hold up the PR insisting on a specific code style.
|
Yeah I looked into it, there are other ways to do it, however they would require a project to reference both Crdt and FwData. This was also a pattern I saw other people suggesting as well, so I decided it was acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of tests in the FW data bridge test project that could be generalized and used for both fwdata and crdt backends. So I made a new MiniLcm.Tests project, moved the code in there and made them abstract. Then extended those abstract tests in both the fwdata and crdt test projects.
You'll notice I didn't migrate the
UpdateComplexFormsTeststhis is due to them being over specified on how we do updates and it turns out that doesn't work well for CRDTswaiting on #1114 before merging this