-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big viewer cleanup #1131
Big viewer cleanup #1131
Conversation
Funny I was just thinking about how big the project view was. I would love to pull stuff out of that to make it smaller |
9267ef8
to
a707581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
over all I like the changes to the Option editors. Part of why they were odd is because of how they were used before when we used FieldEditor
for everything, the way the binding worked there was weird and I kinda hacked it to get it working.
I'd like to see some defaults for some of the callbacks, but I'd be happy to accept it as it is now.
frontend/viewer/src/lib/entry-editor/inputs/CrdtMultiOptionField.svelte
Outdated
Show resolved
Hide resolved
frontend/viewer/src/lib/entry-editor/object-editors/SenseEditor.svelte
Outdated
Show resolved
Hide resolved
frontend/viewer/src/lib/entry-editor/object-editors/SenseEditor.svelte
Outdated
Show resolved
Hide resolved
frontend/viewer/src/lib/entry-editor/object-editors/SenseEditor.svelte
Outdated
Show resolved
Hide resolved
frontend/viewer/src/lib/entry-editor/field-editors/MultiOptionEditor.svelte
Outdated
Show resolved
Hide resolved
so we don't create fake objects
a707581
to
6500e0d
Compare
This is essentially ready for review, except for the fact that it's based off of an unmerged branch.
I was finding it somewhat depressing working on viewer code, so I just went for it. There's much more to do.
MultiOptionEditor
andSingleOptionEditor
that you might not be happy with.Some other code debt I'm eager to get to eventually: