Allow project managers to always remove their projects from orgs #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myieye
force-pushed
the
bug/remove-project-from-org-permission-bug
branch
from
6004c80 to
b47fba2
Compare
C# Unit Tests75 tests 75 ✅ 5s ⏱️ Results for commit 84dba34. ♻️ This comment has been updated with latest results. |
hahn-kev
requested changes
Oct 23, 2024
hahn-kev
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short, to remove a project from an org...
Before this change
You needed to be an org member AND a project manager
Now
You can be an org manager OR a project manager
It seems to me that a project manager should always be able to remove their project from an org, even if they're not a member of the org. It looks like the current logic was just copied from the
AddProjectToOrgmutation. But, I think my change makes more sense.