Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org enhancements #1151

Merged
merged 18 commits into from
Oct 29, 2024
Merged

Org enhancements #1151

merged 18 commits into from
Oct 29, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Oct 23, 2024

Spent a bunch of time just playing with orgs and finding holes. This is the result:

  • Added an Organizations link breadcrumb when your on an org page
  • Made the orgs button always visible in the toolbar (and made adjustments so that there's more space for it)
  • Fixed org sorting, so that case is ignored
  • Fixed "Unknown Error" being shown when using an org name that's already in use
  • Changed the Org name db column to be case-insensitive, because I think that makes a lot of sense (the migration ran fine for me once there were no conflicts and there aren't any conflicts in dev, staging or prod)
  • Partitioned the org list (we sort of decided we'd leave this until someone asked, but I think this is a nice and simple initial solution and it seemed awfully weird that it was not at all visible what orgs you're in):
    image
  • Add confirmations and notifications for removing members and leaving
  • Fixed a bug that prevented normal org members from leaving
  • And some other stuff...

Copy link

github-actions bot commented Oct 23, 2024

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5c2dafa. ± Comparison against base commit b37324e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 23, 2024

C# Unit Tests

75 tests   75 ✅  5s ⏱️
13 suites   0 💤
 1 files     0 ❌

Results for commit 5c2dafa.

♻️ This comment has been updated with latest results.

@myieye myieye marked this pull request as ready for review October 24, 2024 12:34
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@myieye myieye merged commit a84c509 into develop Oct 29, 2024
14 checks passed
@myieye myieye deleted the org-enhancements branch October 29, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants