Use project ID, not code, in CrdtMerge API #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmunn
changed the title
|
Draft PR for now. Once #1170 finishes passing tests, I'll merge it, then rebase this PR on top of it and then we'll be ready for review. |
Use project code and ID in root folder name, use "crdt" and "fw" inside root folder no matter what the project's actual code or name is.
Using the name "crdt" everywhere as a project name caused a couple of caching issues in existing CRDT code, but the change is pretty easy.
rmunn
force-pushed
the
feat/crdtmerge-project-name-and-id
branch
from
987ac61 to
a9aed68
Compare
Details are a bit of a long story but has to do with how AsyncLocal works, and which async variables are in scope at which point.
hahn-kev
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1168.
We now use project code and ID in root folder name, use "crdt" and "fw" inside root folder no matter what the project's actual code or name is.
We also use project ID rather than code in the API request parameters. So now instead of POSTing to
/sync/?projectCode=sena-3, you would POST to/sync/?projectId=0ebc5976-058d-4447-aaa7-297f8569f968.