Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for parallel db access in middleware #1196

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add integration test for parallel db access in middleware #1196

merged 3 commits into from
Nov 5, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Oct 31, 2024

Make waiting for hg repos to be ready explicit

Add integration test for parallel db access in middleware

@myieye myieye marked this pull request as ready for review October 31, 2024 12:35
@myieye Graphite App
Copy link
Contributor Author

myieye commented Oct 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @myieye and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

C# Unit Tests

75 tests  ±0   75 ✅ ±0   5s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 99f8bdc. ± Comparison against base commit b5803ed.

♻️ This comment has been updated with latest results.

@myieye myieye changed the title Make waiting for hg repos to be ready explicit Add integration test for parallel db access in middleware Oct 31, 2024
hahn-kev
hahn-kev reviewed Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@hahn-kev hahn-kev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I had a question and didn't want this to auto merge.

edit: should this fail now because it doesn't include the hot chocolate fix?

backend/Testing/ApiTests/ApiTestBase.cs Show resolved Hide resolved
@myieye myieye force-pushed the test/gql-middleware-race-condition branch from 12622db to 9395b3d Compare November 4, 2024 10:20
@myieye
Copy link
Contributor Author

myieye commented Nov 4, 2024

edit: should this fail now because it doesn't include the hot chocolate fix?

The HC fix is already in develop.

@myieye myieye force-pushed the test/gql-middleware-race-condition branch from 9395b3d to 0402acd Compare November 5, 2024 09:42
@myieye Graphite App
Copy link
Contributor Author

myieye commented Nov 5, 2024 •
edited
Loading

Merge activity

  • Nov 5, 4:43 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 5, 4:48 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 5, 4:52 AM EST: A user merged this pull request with Graphite.

@myieye myieye force-pushed the test/gql-middleware-race-condition branch from 0402acd to 99f8bdc Compare November 5, 2024 09:47
@myieye myieye merged commit 3ed4eb7 into develop Nov 5, 2024
8 checks passed
@myieye myieye deleted the test/gql-middleware-race-condition branch November 5, 2024 09:52
@myieye myieye mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahn-kev hahn-kev hahn-kev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myieye @hahn-kev