Make ProjectMembersVisibilityMiddleware more robust #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hahn-kev
reviewed
Nov 1, 2024
backend/LexBoxApi/GraphQL/CustomTypes/ProjectMembersVisibilityMiddleware.cs
Outdated
Show resolved
Hide resolved
myieye
force-pushed
the
gt/10-31-make_projectmembersvisibilitymiddleware_more_robust
branch
from
b5050b7 to
f037a44
Compare
hahn-kev
approved these changes
Nov 5, 2024
myieye
force-pushed
the
gt/10-31-make_projectmembersvisibilitymiddleware_more_robust
branch
from
f037a44 to
dbbd579
Compare
myieye
deleted the
gt/10-31-make_projectmembersvisibilitymiddleware_more_robust
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed project member visibility to include users even when their full user object hasn't been loaded.
What changed?
Modified the project members visibility middleware to check both the User.Id and UserId properties when filtering project users. This ensures that project members are correctly shown even when the User navigation property hasn't been fully loaded.