-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store repo size (in kB) in database #1221
Conversation
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit b5b8cbd. ♻️ This comment has been updated with latest results. |
Note: currently this does not add an "update" button like the others; instead, the frontend project page automatically issues the updateRepoSizeInKb mutation request if the size is null. That would display a spinner while it updates, but it's so fast (even on the elawa-dev-flex repo) that I've never actually seen the spinner during my testing. But if we want to change this to have the "update" button accessible only to admins (or to project managers?) then I can do that. |
We upgraded from Entity Framework Core 8.0.8 to 8.0.10 a little while ago, so it's best for the dotnet-ef tool to use the same version.
This one is open to anyone who can view the project, so that frontend code can automatically look up the project size if it's missing, with no manual button clicks necessary.
663539c
to
4cccb8e
Compare
Rebased on top of |
frontend/src/routes/(authenticated)/project/[project_code]/+page.svelte
Outdated
Show resolved
Hide resolved
Only use one digit after the decimal point; nobody cares if a project's size is 766.734 MB. 766.7 MB is more than precise enough.
f8df62a
to
c5a4cae
Compare
frontend/src/routes/(authenticated)/project/[project_code]/+page.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good though I'd like to move the updateRepoSize
call, there's no need for that to be reactive it just opens the possibility for it to be called more often then we want
That way it will run a maximum of once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I changed where you put the loading indicator.
Fix #1088.
Work completed:
Screenshot: