Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 1034 mailinator no longer working for automated tests (and other bugs) #1225

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Nov 11, 2024

Resolves #1034
Resolves #1226

Replaces our usage of Mailinator with a package called e2e-mailbox, which uses DeveloperMail.com (and theoretically falls back to try GuerrillaMail.com if DeveloperMail doesn't respond, but I've only excluded the developerdomain from our turnstile check).

Additionally, refactors our Maildev usage to only use the API. That resulted in a decent amount of deleted code 🥳.

As this was perhaps the first time in a while that anyone has run our Playwright tests somewhat extensively, I found a small handful of problems:

  • returnTo in invite links is absolute #1226 (not critical, beacuse the invite workflow seems ok)
  • The Grammatical info of an entry wasn't properly rendered on an initial page load (yes, there was a very similar bug a while back. This was slightly different)
  • 2 testing bugs due to outdated texts
  • Hot Chocolate 14 has largely (or completely?) stopped returning 500's for errors (See here). So, I had to rewrite some of our expectations.

@myieye myieye changed the title 1034 mailinator no longer working for automated tests Fix: 1034 mailinator no longer working for automated tests (and Playwright bugs) Nov 11, 2024
@myieye myieye changed the title Fix: 1034 mailinator no longer working for automated tests (and Playwright bugs) Fix: 1034 mailinator no longer working for automated tests (and other bugs) Nov 11, 2024
Copy link

github-actions bot commented Nov 11, 2024

UI unit Tests

12 tests   12 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 732b082.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 11, 2024

C# Unit Tests

75 tests  ±0   75 ✅ ±0   5s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 732b082. ± Comparison against base commit 85f9555.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thank you! Also thanks for catching that issue with the url, I've made a change to the email service so it'll throw if we try to use an absolute url in the future.

@myieye myieye merged commit faba095 into develop Nov 12, 2024
19 checks passed
@myieye myieye deleted the 1034-mailinator-no-longer-working-for-automated-tests branch November 12, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

returnTo in invite links is absolute Mailinator no longer working for automated tests
2 participants