make api to call fw headless sync #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# Unit Tests90 tests 90 ✅ 5s ⏱️ Results for commit 4862c48. ♻️ This comment has been updated with latest results. |
myieye
previously approved these changes
Nov 19, 2024
…less-sync-from-lexbox
myieye
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1244 but does not close it
found bug #1251 while testing this
closes #1255
adds an API for lexbox to call fw-headless sync, I also took the chance to test out the new service discovery package which standardizes configuring where http service host names are defined. See appsettings.Development.json and lexbox-deployment.yaml for how that's setup