Bug/1258 if you log out you can click the back button and see the previous logged in page #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents us using /logout as a returnTo URL
myieye
force-pushed
the
bug/1258-if-you-log-out-you-can-click-the-back-button-and-see-the-previous-logged-in-page
branch
from
43747e5 to
8145310
Compare
|
It's a bit unfortunate that the Playwright tests don't get executed on frontend-only PRs 🤔 |
myieye
deleted the
bug/1258-if-you-log-out-you-can-click-the-back-button-and-see-the-previous-logged-in-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1258
Sets the
Clear-Site-Data: "cache"header on logout, which tells the browser to clear the browser cache.Juicy change is here: f56f09e
Other commits are for:
We can clear more stuff, but I'm not sure if we want to: