Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update(before, after) API for example sentences #1266

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Nov 25, 2024

Fix #1187.

Adds a new UpdateExampleSentence(Guid entryId, Guid senseId, ExampleSentence before, ExampleSentence after) method to the IMiniLcmWriteApi interface.

Also adds a GetExampleSentence(Guid entryId, Guid senseId, Guid id) method to the IMiniLcmReadApi interface.

@rmunn rmunn self-assigned this Nov 25, 2024
@rmunn rmunn requested a review from hahn-kev November 25, 2024 05:13
Copy link

C# Unit Tests

90 tests  ±0   90 ✅ ±0   5s ⏱️ ±0s
14 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e33fc9e. ± Comparison against base commit 3a69401.

@rmunn rmunn merged commit 6476ba6 into develop Nov 28, 2024
15 of 16 checks passed
@rmunn rmunn deleted the feat/new-update-api-example-sentences branch November 28, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement new update api for example sentences
2 participants