Add Update(before, after) API for senses #1267
Conversation
C# Unit Tests98 tests 98 ✅ 5s ⏱️ Results for commit 10e672a. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
this looks like a good start, though SenseDiffToUpdateneeds to be changed to remove the code doing the diff on semantic domains and instead in in SenseSync.Sync it needs to do a collection diff and use the apis AddSemanticDomainToSense and the remove variant, if there's any differences between the same domains those should be ignored.
Done in commit 95441bb. |
|
Since merging |
|
@rmunn yes that's expected, you can configure that test to ignore SemanticDomains, that set of tests is really only checking the diff update produced on the basic fields of an object, eg changes which go through |
rmunn
force-pushed
the
feat/new-update-api-senses
branch
from
ed47f90 to
db8aff0
Compare
|
Note that this PR has the (after, before) ordering in it; that will be fixed by #1303, so we should not change it here lest merge resolution end up doing the wrong thing. |
Rebasing into develop pulled in a change that LfClassicMiniLcmApi didn't yet implement. Since LF Classic doesn't handle complex forms, the implementation is dead simple: just return null.
Fix #1186.
Adds a new UpdateSense(Guid entryId, Sense before, Sense after) method to the IMiniLcmWriteApi interface.
Also adds a GetSense(Guid entryId, Guid id) method to the IMiniLcmReadApi interface.