Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project managers invited by email can create projects #1300

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Dec 3, 2024

If someone is promoted to manager by other means, they can create projects without needing a draft project approved by an admin. Sending an email invitation to a new user and giving them the project-manager role right off the bat should have the same effect.

We also apply the same logic to org admins: if someone is invited as an org admin, we trust them enough to let them create new projects.

Fixes #1297.

If someone is promoted to manager by other means, they can create
projects without needing a draft project approved by an admin. Sending
an email invitation to a new user and giving them the project-manager
role right off the bat should have the same effect.
@rmunn rmunn requested a review from hahn-kev December 3, 2024 06:13
@rmunn rmunn self-assigned this Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

C# Unit Tests

98 tests  ±0   98 ✅ ±0   5s ⏱️ ±0s
15 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5687ca9. ± Comparison against base commit 62e2c19.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test this? I'm not sure this is enough to fix the bug

@rmunn
Copy link
Contributor Author

rmunn commented Dec 3, 2024

Not yet; it looked like enough, but I'll test to confirm.

@rmunn
Copy link
Contributor Author

rmunn commented Dec 3, 2024

@hahn-kev - With commit 5687ca9, this appears to work: I sent an invitation to a new account to join an existing project as a manager, and the new account was able to immediately create new projects.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for testing it to ensure this fixes the bug

@rmunn rmunn merged commit 9ab9b37 into develop Dec 4, 2024
8 checks passed
@rmunn rmunn deleted the bug/invited-managers-can-create-projects branch December 4, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inviting users as mangers does not give them permission to create new projects
2 participants