Code

Feat/1246 Allow reordering senses#1308

Code

Merged

myieye merged 29 commits intodevelopsillsdev/languageforge-lexbox:developfrom feat/1246-allow-reordering-senses-example-sentences-complex-forms-and-componentssillsdev/languageforge-lexbox:feat/1246-allow-reordering-senses-example-sentences-complex-forms-and-componentsCopy head branch name to clipboardDec 18, 2024

+1,222-305

Commits

Commits on Dec 10, 2024

• Add collection position diffing

  myieye

  committed
  d8cb48b

  Copy full SHA for d8cb48b

• Add some collection diff tests and redesign to use after/before positioning

  myieye

  committed
  62864b2

  Copy full SHA for 62864b2

• Exclude Order from external serialization, refactor, add more tests

  myieye

  committed
  80850a7

  Copy full SHA for 80850a7

• Update/extend entry tests for sense reordering and cleanup

  myieye

  committed
  df2a15e

  Copy full SHA for df2a15e

• Rename method

  myieye

  committed
  028203f

  Copy full SHA for 028203f

• Don't set order on moved sense, because it shouldn't be necessary to set an internal property for an external caller.

  myieye

  committed
  7df8aea

  Copy full SHA for 7df8aea

• Set sense order when creating entries in bulk

  myieye

  committed
  1726b5a

  Copy full SHA for 1726b5a

• Standardize using AllSenses (not SensesOS) and fix moving between subsenses

  myieye

  committed
  9d7b850

  Copy full SHA for 9d7b850

• Cleanup

  myieye

  committed
  c5f30ca

  Copy full SHA for c5f30ca

• Fix tests

  myieye

  committed
  970a43c

  Copy full SHA for 970a43c

• Revert making Sense partial

  myieye

  committed
  b3bf2be

  Copy full SHA for b3bf2be

• Sort senses in place

  myieye

  committed
  5f5a492

  Copy full SHA for 5f5a492

• Refactor OrderPicker to require siblings

  myieye

  committed
  a87b7ba

  Copy full SHA for a87b7ba

• Rename BetweenPosition props and simplify orderable methods

  myieye

  committed
  cebb3d5

  Copy full SHA for cebb3d5

• Refactor collection diffing to use class/object for add, delete, move & replace

  myieye

  committed
  b82d56b

  Copy full SHA for b82d56b

Commits on Dec 11, 2024

• add back a comment which got lost

  hahn-kev

  committed
  4eda0bd

  Copy full SHA for 4eda0bd

• simplify generating random moves for entry sync tests

  hahn-kev

  committed
  4085b10

  Copy full SHA for 4085b10

• specify a namespace for the MiniLcmJson class

  hahn-kev

  committed
  01106a4

  Copy full SHA for 01106a4

• add comment about what the MiniLcmInternalAttribute.cs is used for

  hahn-kev

  committed
  5ebbced

  Copy full SHA for 5ebbced

Commits on Dec 12, 2024

• Fix failing test

  myieye

  committed
  490ac23

  Copy full SHA for 490ac23

Commits on Dec 13, 2024

• Only pass senseId to MoveSense

  myieye

  committed
  7c9450b

  Copy full SHA for 7c9450b

• Use letters for test glosses, because orders use int

  myieye

  committed
  121ebf3

  Copy full SHA for 121ebf3

• Don't mock IOrderable in tests

  myieye

  committed
  59b1db5

  Copy full SHA for 59b1db5

• Revert unintended extra sync

  myieye

  committed
  68587bf

  Copy full SHA for 68587bf

• Fix SetOrderChange type discriminator(s)

  myieye

  committed
  eabc7a7

  Copy full SHA for eabc7a7

• Optimize order picker

  myieye

  committed
  1e4d485

  Copy full SHA for 1e4d485

• Refactor Orderable diffing with custom diff formatter

  myieye

  committed
  ea86354

  Copy full SHA for ea86354

• Merge remote-tracking branch 'origin/develop' into feat/1246-allow-reordering-senses-example-sentences-complex-forms-and-components

  myieye

  committed
  72d170a

  Copy full SHA for 72d170a

Commits on Dec 18, 2024

• Incorporated PR feedback

  myieye

  committed
  42a0418

  Copy full SHA for 42a0418