Mark more tests as integration, beacuse they use Postgres #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we probably need a 3rd category, because these tests do run in CI during the build (which means we catch them early, as opposed to integration) because we setup a postgres DB for these tests which is why they haven't been failing there. I don't really want to shift these tests to run later because they can run earlier without issue. That would also be why these tests are now failing in the integration test phase |
myieye
force-pushed
the
make-more-tests-integration
branch
from
1d68d36 to
94082eb
Compare
hahn-kev
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests fail if Postgres isn't available, so it seems reasonable to me to mark them as integration tests.