Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm deleting fwlite entries #1337

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Jan 6, 2025

closes #1332

this PR creates a DeleteDialog, which is placed in the app root and injected into a dialog service, this service is then available via useDialogService which uses getContext. This allows calling dialogService.promptDelete('my object') from anywhere and it will prompt for deleting with the provided text.

@hahn-kev hahn-kev requested a review from myieye January 6, 2025 03:42
Copy link

github-actions bot commented Jan 6, 2025

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 1ff874b. ± Comparison against base commit 7050665.

Copy link

github-actions bot commented Jan 6, 2025

C# Unit Tests

103 tests  ±0   103 ✅ ±0   5s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1ff874b. ± Comparison against base commit 7050665.

@hahn-kev hahn-kev merged commit 64ca37e into develop Jan 6, 2025
20 checks passed
@hahn-kev hahn-kev deleted the feat/confirm-delete-fw-lite branch January 6, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confim deleting objects
1 participant