Make new entries appear in navigation list #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `{dontNavigate: true}` so that the search bar won't be changed.
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit 51398bb. |
C# Unit Tests103 tests 103 ✅ 5s ⏱️ Results for commit 51398bb. |
hahn-kev
reviewed
Jan 13, 2025
myieye
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1327.
I have chosen to use the
{dontNavigate: true}option when callingonEntryCreatedso that the search bar won't be changed, because I found the UX of having other entries disappear from the left-side list to be confusing. I opened #1366 to track one idea I had for changing that UX.