make activity changes textbox readonly #1370
Conversation
|
@hahn-kev So, I pushed this. What do you think? Right is readonly. I basically copied IBM's Carbon design system.
|
I see that on the right there are no buttons to add or delete. Also, that there is not a different background behind the text. I think some people may still miss those clues. If someone tries to edit that text, is there any way the app could show a kind of toaster notification in the bottom middle that the text is read-only? Ideally it would auto-dissapear after a few seconds. Paratext also does this, but it's a bit wordy. |
|
@alex-larkin at the moment the read only view is used in the history dialog. It seems a bit redundant to say you can't change history. But I like the idea of a toast, especially for the viewer (on lexbox) which is all readonly. Tim that looks great, I'm going to try to merge this in, also you made a fix for the testing view, that will also be required for the viewer... some day we won't forget you viewer. |
|
Oh okay. I thought this was for accounts with read-only permissions. For someone whose navigated to the history it should be fine. |
closes #1329 #1331
Taking a look at the history dialog in readonly mode it looks strange as it feels hard to tell what's data and what's not:
I think it looks better with the borders, it's not obvious that it's readonly, but trying to edit will make that obvious.
@myieye what do you think?
I also noticed a bug that the Complex Forms field is empty in history view so I've made #1369 to track that issue