Improve password-checking regex

[rmunn]

Now that we've verified that only the three symbols &, +, and % cause problems in passwords submitted through Chorus, we can loosen the password rules to allow any character except those three.

Fixes #255.

[github-actions]

UI unit Tests

1 tests   1 ✔️  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 0b3c5b1.

♻️ This comment has been updated with latest results.

[rmunn]

Converted to draft since I just saw this part of #255:

Send/Receive didn't work with the password: test-temp-0:?"!$. I'm not sure what the culprit is exactly

I tested the Chorus "Login" button but not a full Send/Receive. I'll add a full Send/Receive to my tests to determine whether other characters besides &, % and + might cause further issues.

[rmunn]

Can't confirm Tim's experience that the password test-temp-0:?"!$ caused issues; it worked fine for me, including doing a full Send/Receive. I also checked many other special characters in a full S/R and not just logging in, and they all worked. So I'm restoring this PR to non-draft, because +, &, and % are indeed the only characters we need to worry about.

[myieye]

Thanks so much for doing the researching and finishing this up!
I just think the error message should be a bit shorter

[myieye]

I still find the error message a bit odd.
"can cause problems" sounds more like "You can use them if you want, but something bad might happen somewhere".

From our perspective we don't allow these characters because they break S/R.
From a user perspective, they're just not allowed. If we want an explination (which I don't think is absolutely necessary, we could say something like "for backwards compatibility purposes") 🤷