Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable logging trace id to console in .NET #376

Merged
merged 1 commit into from
Nov 13, 2023
Merged

enable logging trace id to console in .NET #376

merged 1 commit into from
Nov 13, 2023

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Nov 9, 2023 •
edited
Loading

ensures that we always log the trace id to console when relevant

example output:

info: Microsoft.AspNetCore.Hosting.Diagnostics[1]
      => TraceId:4b2f3f89c012b65368eaa39e378c78bf => ConnectionId:0HMV0RGDNJRM9 => RequestPath:/api/login RequestId:0HMV0RGDNJRM9:00000001
      Request starting HTTP/1.1 POST http://localhost:3000/api/login application/json 115

@hahn-kev hahn-kev changed the title enable logging trace id to console enable logging trace id to console in .NET Nov 9, 2023
@hahn-kev hahn-kev mentioned this pull request Nov 9, 2023
Closed
@hahn-kev hahn-kev requested a review from myieye November 9, 2023 04:30
@hahn-kev hahn-kev marked this pull request as ready for review November 9, 2023 04:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

C# Unit Tests

34 tests  ±0   34 ✔️ ±0   15s ⏱️ +3s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 149ef16. ± Comparison against base commit 22c5f0a.

@myieye
Copy link
Contributor

myieye commented Nov 9, 2023

Magic 🪄

myieye
myieye approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew I made a PR our of my changes for a reason 😆

@hahn-kev hahn-kev merged commit e7e9c05 into develop Nov 13, 2023
5 checks passed
@hahn-kev hahn-kev deleted the enable-logging-trace-id-globally branch July 9, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myieye myieye myieye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hahn-kev @myieye