Create E2E tests for reset-project feature #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After discussion with Kevin today, we decided to lower the |
rmunn
force-pushed
the
chore/test-reset-repo
branch
from
7899354 to
ec35883
Compare
|
Rebased on top of develop; now the number of commits is actually correct. |
This should help minimize the number of times the Send/Receive tests run into a race condition where a new test has been created on the hgweb server, but Mercurial hasn't yet picked it up.
The new SendReceiveAfterProjectReset test is passing now that hgweb is checking for new repos every 5 seconds; let's try to ensure that it stays reliable by adding 5-second sleeps in the right places.
Now the resetProject.test.ts file will run again.
Now we check after the project has been reset to verify that it's at the same hash, with the same number of files at the top level, as before the reset-and-upload process.
This fixture creates a temporary project and deletes it afterwards.
This is about the smallest Mercurial repo possible that isn't empty: a repo with just one commit of an empty file. We'll use this in E2E testing to populate new projects.
Greatly expanded the reset-project Playwright test: - It uses a temp project now, whose name is based on a hash of the test title and browser settings, so Chromium and Firefox will use different project names. This will allow the test to run in parallel with itself. - It uploads a known initial state of a Mercurial repo, which is a tiny zip file containing just one commit. - It checks that the project-reset modal dialog can reset the project to an empty state or upload from a zip file correctly. Combined with the .NET test that confirms that a project can still be used with Send/Receive after resetting to an empty state, that should cover just about everything.
rmunn
force-pushed
the
chore/test-reset-repo
branch
from
bde8e27 to
8a98102
Compare
|
Rebased on top of latest |
hahn-kev
requested changes
Feb 9, 2024
myieye
approved these changes
Feb 12, 2024
Co-authored-by: Tim Haasdyk <[email protected]>
Co-authored-by: Tim Haasdyk <[email protected]>
If two copies of the test run simultaneously in Chromium and Firefox,
you can end up with the situation where one of them sees two copies of
the test project in the admin dashboard. And while they have different
project codes, until now they had the same project name. However, since
the admin dashboard code to click on the project uses the project name
(with `{exact: true}`), the locator was seeing two copies of the
project, and therefore throwing an error.
This commit fixes that by putting the test ID (which is different for
each browser) into the project name as well as the project code, so that
the admin dashboard locators will only ever find a single project.
One locator was using this.page instead of this.componentLocator, because of an error that turned out to be unrelated. So it can be switched back to using this.componentLocator again.
This should save some time, as the browser tab won't have to load and render the hgweb HTML. It also lets us make more fine-grained checks of the results, since we're getting back JSON structures that we know will have certain properties.
Note that this doesn't actually improve the type safety of this code at all, since Typescript just takes our word for it that we know the structure of the JSON returned by that particular fetch request. But it makes the linter happy not to get Typescript errors.
We're changing the clickResetProject() method to actually return a ResetProjectModal instance as the return type suggests, and to wait for it so there's no need for the `waitFor()` calls in the calling function.
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #440.
Fix #515.
This PR creates two tests: