-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S/R tests with Mercurial 6 #716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest Chorus version has some bugfixes to the Linux Mercurial package.
C# Unit Tests26 tests 26 ✅ 4s ⏱️ Results for commit ed5e32b. ♻️ This comment has been updated with latest results. |
On Mercurial 3 test runs, the step that builds Python from source installs the virtuelenv package already.
hg push is timing out on develop server so it's hard to tell what's going on as the "Thread abort unsupported on this platform" exception swallows the original one. Temporarily triple the hg push timeout so we have a chance of seeing what's going on.
This reverts commit 00830b6.
rmunn
force-pushed
the
chore/fix-sr-tests-hg-6
branch
from
April 11, 2024 04:43
eea0df6
to
b0f1fc8
Compare
The "Publish unit test results" step needs it. It's not strictly necessary if we're running tests against Mercurial 3 since the Python 2 envrionment that setup-python installs does have virtualenv in it, but it's simpler to just install it all the time.
myieye
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see how this works against staging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #710, but not yet a fix for it (maybe) — self-hosted runner still isn't passing the SendReceiveAfterProjectReset test, so I can't prove whether this is actualy a fix for issue #710 or not.
We update Chorus to the latest version, which has some bugfixes to the Linux Mercurial package. This makes the SendReceiveAfterProjectReset test pass on my machine. If it fails when run against develop or staging, then there might be something else going on as well.