Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hg pod access from dev and non-dev namespaces #790

Merged
merged 1 commit into from
May 8, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented May 7, 2024

Should fix #783.

Note that the namespace tag of the network policy remains languagedepot. That tag should be adjusted by the Fleet deployment just the same as the namespace tags in all the other Kubernetes configs; it's the namespaceSelectors that weren't adjusted.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple, I like it.

@rmunn rmunn merged commit 442104b into develop May 8, 2024
3 checks passed
@rmunn
Copy link
Contributor Author

rmunn commented May 8, 2024

Can confirm that this works; I deployed this to the develop server after merging and now I can access the hg pod again, so things like the commit train-tracks graph are working again on develop.

@myieye myieye deleted the chore/783-network-policy-namespace branch May 10, 2024 08:08
@rmunn rmunn self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access hg pod in develop
2 participants