Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deleteDraftProject GQL mutation #796

Merged
merged 5 commits into from
May 16, 2024
Merged

Add deleteDraftProject GQL mutation #796

merged 5 commits into from
May 16, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented May 13, 2024

Fixes #795.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b13e2f4. ± Comparison against base commit 2869a47.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

C# Unit Tests

35 tests   35 ✅  6s ⏱️
 8 suites   0 💤
 1 files     0 ❌

Results for commit b13e2f4.

♻️ This comment has been updated with latest results.

@rmunn rmunn marked this pull request as ready for review May 13, 2024 09:58
@rmunn rmunn requested a review from myieye May 13, 2024 09:58
myieye
myieye requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment as well as this one 🙂: I think it makes sense to remove the draft-project logic from our other delete mutation.

backend/LexBoxApi/GraphQL/ProjectMutations.cs Outdated Show resolved Hide resolved
hahn-kev
hahn-kev requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, glad this wasn't too hard to correct.

backend/LexBoxApi/GraphQL/ProjectMutations.cs Outdated Show resolved Hide resolved
@rmunn
Copy link
Contributor Author

rmunn commented May 14, 2024

1 comment as well as this one 🙂: I think it makes sense to remove the draft-project logic from our other delete mutation.

Also done.

@rmunn rmunn requested review from hahn-kev and myieye May 14, 2024 01:59
@rmunn rmunn self-assigned this May 14, 2024
@rmunn rmunn requested a review from myieye May 15, 2024 08:21
@rmunn
Copy link
Contributor Author

rmunn commented May 15, 2024

@myieye - Now that Kevin has approved this (modulo the change that I just made), want to approve it too so GitHub will unlock the merge button?

@rmunn rmunn merged commit cc97afe into develop May 16, 2024
14 checks passed
@myieye myieye deleted the bug/795-deleteDraftProject branch October 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myieye myieye myieye approved these changes

@hahn-kev hahn-kev hahn-kev approved these changes

Assignees

@rmunn rmunn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create proper deleteDraftProject GQL mutation
3 participants
@rmunn @hahn-kev @myieye