Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump otel and npm packages #804

Merged
merged 2 commits into from
May 17, 2024
Merged

Bump otel and npm packages #804

merged 2 commits into from
May 17, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented May 16, 2024

Dependabot opened several muddled PRs for some security fixes for Otel and Vite packages.
This covers that and obviously a lot more.

Instrumentation for ASP .NET Core also started redacting query param values by default.
I disabled that, because we have no concrete reason to think that we need it, our JWT reaction is working well.
And query params can obviously be handy (e.g. for debugging resumable transactions)

It turns out that svelte-check starts breaking when we update to typescript +5.4.2 (because it seems to think that the built viewer.js should be TS 😕).
That took a surprisingly long time to figure out. Anyway, I decided not to update typescript.

Copy link

github-actions bot commented May 16, 2024

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4c6ebbf. ± Comparison against base commit cc97afe.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

C# Unit Tests

35 tests  ±0   35 ✅ ±0   5s ⏱️ ±0s
 8 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4c6ebbf. ± Comparison against base commit cc97afe.

♻️ This comment has been updated with latest results.

@myieye myieye force-pushed the chore/bump-for-security-patches branch from 52aee18 to 4c6ebbf Compare May 16, 2024 09:33
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, once the page loads for the first time I can just navigate around the app without having to reload every page, this is awesome!

@myieye myieye merged commit 4b5cca5 into develop May 17, 2024
14 checks passed
@myieye myieye deleted the chore/bump-for-security-patches branch May 17, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants